netdev - Re: [PATCH 1/2] net: dsa: RCU-protect dsa_ptr in struct net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a89dfb1524d9592a5077d2a7a34dceed579e7d3d.camel@siemens.com>
Date: Tue, 10 Sep 2024 20:40:26 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"florian.fainelli@...adcom.com" <florian.fainelli@...adcom.com>
CC: "andrew@...n.ch" <andrew@...n.ch>, "olteanv@...il.com"
	<olteanv@...il.com>, "bridge@...ts.linux.dev" <bridge@...ts.linux.dev>,
	"claudiu.manoil@....com" <claudiu.manoil@....com>, "dqfext@...il.com"
	<dqfext@...il.com>, "nbd@....name" <nbd@....name>, "davem@...emloft.net"
	<davem@...emloft.net>, "stable@...r.kernel.org" <stable@...r.kernel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "Mark-MC.Lee@...iatek.com"
	<Mark-MC.Lee@...iatek.com>, "UNGLinuxDriver@...rochip.com"
	<UNGLinuxDriver@...rochip.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"arinc.unal@...nc9.com" <arinc.unal@...nc9.com>,
	"alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"bcm-kernel-feedback-list@...adcom.com"
	<bcm-kernel-feedback-list@...adcom.com>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "daniel@...rotopia.org"
	<daniel@...rotopia.org>, "razor@...ckwall.org" <razor@...ckwall.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "sean.wang@...iatek.com"
	<sean.wang@...iatek.com>, "roopa@...dia.com" <roopa@...dia.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "f.fainelli@...il.com"
	<f.fainelli@...il.com>, "lorenzo@...nel.org" <lorenzo@...nel.org>
Subject: Re: [PATCH 1/2] net: dsa: RCU-protect dsa_ptr in struct net_device

Hi Florian!

On Tue, 2024-09-10 at 10:40 -0700, Florian Fainelli wrote:
> > RCU-protect dsa_ptr and use rcu_dereference() or rtnl_dereference()
> > depending on the calling context.
> > 
> > Rename netdev_uses_dsa() into __netdev_uses_dsa_currently()
> > (assumes ether RCU or RTNL lock held) and netdev_uses_dsa_currently()
> > variants which better reflect the uselessness of the function's
> > return value, which becomes outdated right after the call.
> > 
> > Fixes: ee534378f005 ("net: dsa: fix panic when DSA master device unbinds on shutdown")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> 
> Thanks for doing this work, just a few nits below. This is likely to be 
> difficult to backport to stable trees.

Thanks for the quick feedback!
As I've mentioned in the cover letter, I've v6.1 backport already available
and I'm ready to backport to v6.8 as soon as we agree on the final form for
v6.11.

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com