netdev - Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29017a97-7a5c-49eb-b866-e6b22fd8baea@oracle.com>
Date: Wed, 11 Sep 2024 12:30:49 -0700
From: Si-Wei Liu <si-wei.liu@...cle.com>
To: "Michael S. Tsirkin" <mst@...hat.com>,
        Darren Kenny <darren.kenny@...cle.com>
Cc: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, virtualization@...ts.linux.dev,
        Jason Wang <jasowang@...hat.com>,
        Eugenio Pérez
 <eperezma@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by
 default"



On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote:
> Thanks a lot!
> Could you retest Xuan Zhuo original patch
Which one? I thought Darren already did so?

-Siwei
>   just to make sure it does
> not fix the issue?
>
> On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote:
>> For the record, I got a chance to test these changes and confirmed that
>> they resolved the issue for me when applied on 6.11-rc7.
>>
>> Tested-by: Darren Kenny <darren.kenny@...cle.com>
>>
>> Thanks,
>>
>> Darren.
>>
>> PS - I'll try get to looking at the other potential fix when I have time.
>>
>> On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote:
>>> On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
>>>> Regression: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com
>>>>
>>>> I still think that the patch can fix the problem, I hope Darren can re-test it
>>>> or give me more info.
>>>>
>>>>      http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com
>>>>
>>>> If that can not work or Darren can not reply in time, Michael you can try this
>>>> patch set.
>>> Just making sure netdev maintainers see this, this patch is for net.
>>>
>>>> Thanks.
>>>>
>>>> Xuan Zhuo (3):
>>>>    Revert "virtio_net: rx remove premapped failover code"
>>>>    Revert "virtio_net: big mode skip the unmap check"
>>>>    virtio_net: disable premapped mode by default
>>>>
>>>>   drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
>>>>   1 file changed, 46 insertions(+), 49 deletions(-)
>>>>
>>>> --
>>>> 2.32.0.3.g01195cf9f