netdev - Re: [PATCH net v1] dev_ioctl: fix the type of ifr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240910205642.2d4a64ca@hermes.local>
Date: Tue, 10 Sep 2024 20:56:42 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Atlas Yu <atlas.yu@...onical.com>
Cc: kuba@...nel.org, edumazet@...gle.com, davem@...emloft.net,
 pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v1] dev_ioctl: fix the type of ifr_flags

On Wed, 11 Sep 2024 11:46:08 +0800
Atlas Yu <atlas.yu@...onical.com> wrote:

> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> index 797ba2c1562a..b612b6cd7446 100644
> --- a/include/uapi/linux/if.h
> +++ b/include/uapi/linux/if.h
> @@ -244,7 +244,7 @@ struct ifreq {
>  		struct	sockaddr ifru_broadaddr;
>  		struct	sockaddr ifru_netmask;
>  		struct  sockaddr ifru_hwaddr;
> -		short	ifru_flags;
> +		unsigned int	ifru_flags;
>  		int	ifru_ivalue;
>  		int	ifru_mtu;
>  		struct  ifmap ifru_map;

NAK
This breaks userspace ABI. There is no guarantee that
older application correctly zeros the upper flag bits.