netdev - Re: [PATCH net v1] dev_ioctl: fix the type of ifr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240911042050.45254-1-atlas.yu@canonical.com>
Date: Wed, 11 Sep 2024 12:20:47 +0800
From: Atlas Yu <atlas.yu@...onical.com>
To: stephen@...workplumber.org
Cc: atlas.yu@...onical.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net v1] dev_ioctl: fix the type of ifr_flags

On Wed, Sep 11, 2024 at 11:56 AM
Stephen Hemminger <stephen@...workplumber.org> wrote:
> On Wed, 11 Sep 2024 11:46:08 +0800
> Atlas Yu <atlas.yu@...onical.com> wrote:
> > diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> > index 797ba2c1562a..b612b6cd7446 100644
> > --- a/include/uapi/linux/if.h
> > +++ b/include/uapi/linux/if.h
> > @@ -244,7 +244,7 @@ struct ifreq {
> >               struct  sockaddr ifru_broadaddr;
> >               struct  sockaddr ifru_netmask;
> >               struct  sockaddr ifru_hwaddr;
> > -             short   ifru_flags;
> > +             unsigned int    ifru_flags;
> >               int     ifru_ivalue;
> >               int     ifru_mtu;
> >               struct  ifmap ifru_map;
>
> NAK
> This breaks userspace ABI. There is no guarantee that
> older application correctly zeros the upper flag bits.

Thanks, any suggestions though? How about introducing
another ioctl request for these extended bits.