netdev - Re: [PATCH net-next 5/5] net: tn40xx: register swnode and connect it to the mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04d22526-205b-4a59-b344-5bafdb9ce37f@lunn.ch>
Date: Fri, 13 Sep 2024 14:46:06 +0200
From: Andrew Lunn <andrew@...n.ch>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: hfdevel@....net, netdev@...r.kernel.org, hkallweit1@...il.com,
	linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net-next 5/5] net: tn40xx: register swnode and connect it
 to the mdiobus

> >  #define TN40_MDIO_CMD_READ BIT(15)
> > 
> > +#define AQR105_FIRMWARE "tehuti/aqr105-tn40xx.cld"
> 
> This firmware is for AQR PHY so aquantia directory is the better
> place?

I don't know the correct answer to this. One thing to consider is how
it gets packaged.

on my Debian system:

p   firmware-adi                                             - Binary firmware for Analog Devices Inc. DSL modem chips (dummmy pac
i   firmware-amd-graphics                                    - Binary firmware for AMD/ATI graphics chips                         
p   firmware-ast                                             - Binary firmware for ASpeed Technologies graphics chips             
p   firmware-ath9k-htc                                       - firmware for AR7010 and AR9271 USB wireless adapters               
p   firmware-ath9k-htc-dbgsym                                - QCA ath9k-htc Firmware ELF file                                    
p   firmware-atheros                                         - Binary firmware for Qualcomm Atheros wireless cards                
p   firmware-b43-installer                                   - firmware installer for the b43 driver                              
p   firmware-b43legacy-installer                             - firmware installer for the b43legacy driver                        
p   firmware-bnx2                                            - Binary firmware for Broadcom NetXtremeII                           
p   firmware-bnx2x                                           - Binary firmware for Broadcom NetXtreme II 10Gb                     
p   firmware-brcm80211                                       - Binary firmware for Broadcom/Cypress 802.11 wireless cards

It seems to get packaged by vendor. Given the mess aquantia firmware
is, we are going to end up with lots of firmwares in firmware-aquantia
which are never needed. If the firmware is placed into tehuti,
installing firmware-tehuti gives you just what you need.

So i can see the logic of tehuti/aqr105-tn40xx.cld

	Andrew