netdev - Re: [PATCH net-next 1/4] mlx4/mlx5: {mlx4,mlx5e}_en_get_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b979753-9f5a-410c-9fe3-d2366976e316@ans.pl>
Date: Fri, 13 Sep 2024 19:12:01 -0700
From: Krzysztof Olędzki <ole@....pl>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Ido Schimmel <idosch@...dia.com>, Tariq Toukan <tariqt@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
        Yishai Hadas <yishaih@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] mlx4/mlx5: {mlx4,mlx5e}_en_get_module_info
 cleanup

On 13.09.2024 at 13:55, Jakub Kicinski wrote:
> On Wed, 11 Sep 2024 23:38:45 -0700 Krzysztof Olędzki wrote:
>> Use SFF8024 constants defined in linux/sfp.h instead of private ones.
>>
>> Make mlx4_en_get_module_info() and mlx5e_get_module_info() to look
>> as close as possible to each other.
>>
>> Simplify the logic for selecting SFF_8436 vs SFF_8636.
> 
> Minor process suggestion, I think you may be sending the patches one by
> one. It's best to format them into a new directory and send all at once
> with git send-email. Add a cover letter, too.
> 

Thanks, yes, will do for v2. I assume this needs to wait for about two weeks for net-next to re-open?

Krzysztof