netdev - Re: [PATCH net] net: phy: qt2025: Fix warning: unused import DeviceId

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20240919.062907.1995257915073920166.fujita.tomonori@gmail.com>
Date: Thu, 19 Sep 2024 06:29:07 +0000 (UTC)
From: FUJITA Tomonori <fujita.tomonori@...il.com>
To: netdev@...r.kernel.org
Cc: rust-for-linux@...r.kernel.org, andrew@...n.ch, tmgross@...ch.edu,
 lkp@...el.com
Subject: Re: [PATCH net] net: phy: qt2025: Fix warning: unused import
 DeviceId

On Thu, 19 Sep 2024 04:37:07 +0000
FUJITA Tomonori <fujita.tomonori@...il.com> wrote:

> Fix the following warning when the driver is compiled as built-in:
> 
>>> warning: unused import: `DeviceId`
>    --> drivers/net/phy/qt2025.rs:18:5
>    |
>    18 |     DeviceId, Driver,
>    |     ^^^^^^^^
>    |
>    = note: `#[warn(unused_imports)]` on by default
> 
> device_table in module_phy_driver macro is defined only when the
> driver is built as module. Use an absolute module path in the macro
> instead of importing `DeviceId`.

Oops, the last sentence isn't correct. It should've been something like:

Use phy::DeviceId in the macro instead of importing `DeviceId` since
`phy` is always used.