netdev - Re: [PATCH net] net: phy: qt2025: Fix warning: unused import DeviceId

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH5fLgiJyvSztvCDz8KZ4kF0--a0mqi7M4WowB==CCs2FmVk8A@mail.gmail.com>
Date: Thu, 19 Sep 2024 08:17:42 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, 
	tmgross@...ch.edu, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net] net: phy: qt2025: Fix warning: unused import DeviceId

On Thu, Sep 19, 2024 at 6:39 AM FUJITA Tomonori
<fujita.tomonori@...il.com> wrote:
>
> Fix the following warning when the driver is compiled as built-in:
>
> >> warning: unused import: `DeviceId`
>    --> drivers/net/phy/qt2025.rs:18:5
>    |
>    18 |     DeviceId, Driver,
>    |     ^^^^^^^^
>    |
>    = note: `#[warn(unused_imports)]` on by default
>
> device_table in module_phy_driver macro is defined only when the
> driver is built as module. Use an absolute module path in the macro
> instead of importing `DeviceId`.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409190717.i135rfVo-lkp@intel.com/
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>

It may be nice to change the macro to always use the expression so
that this warning doesn't happen again.

Anyway, that is a separate issue.

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>