netdev - Re: [PATCH] octeontx2-af: Change block parameter to const pointer in get_lf_str

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240919151011.GG1571683@kernel.org>
Date: Thu, 19 Sep 2024 16:10:11 +0100
From: Simon Horman <horms@...nel.org>
To: Riyan Dhiman <riyandhiman14@...il.com>
Cc: sgoutham@...vell.com, lcherian@...vell.com, gakula@...vell.com,
	jerinj@...vell.com, hkelam@...vell.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	rsaladi2@...vell.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] octeontx2-af: Change block parameter to const pointer in
 get_lf_str_list

On Thu, Sep 19, 2024 at 02:49:36PM +0530, Riyan Dhiman wrote:
> Convert struct rvu_block block to const struct rvu_block *block in
> get_lf_str_list() function parameter. This improves efficiency by
> avoiding structure copying and reflects the function's read-only
> access to block.
> 
> Fixes: e77bcdd1f639 (octeontx2-af: Display all enabled PF VF rsrc_alloc entries.)
> Signed-off-by: Riyan Dhiman <riyandhiman14@...il.com>

Hi Riyan,

Thanks for your patch.

While I agree that this is a nice change I don't feel that it is
a fix, typically something that addresses a user-visible bug.

I suggest that the patch should be treated as an enhancement.
It should not have a Fixes tag. And it should be targeted at
net-next (as opposed to net, which is, in general, for fixes).

	Subject: [PATCH net-next] ...

Please note that net-next is currently closed for the v6.12 merge window.
It should reopen after v6.12-rc1 has been released, likely during
the week of the 30th September.

So please consider reposting your patch once net-next has reopened.

Link: https://docs.kernel.org/process/maintainer-netdev.html

-- 
pw-bot: defer