netdev - Re: [Intel-wired-lan] [PATCH v7 net-next 02/15] netlink: spec: add shaper YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29e3378c-5f12-480e-8531-d1afa7d840dd@redhat.com>
Date: Thu, 19 Sep 2024 17:11:14 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: netdev@...r.kernel.org, Jiri Pirko <jiri@...nulli.us>,
 Sridhar Samudrala <sridhar.samudrala@...el.com>,
 Donald Hunter <donald.hunter@...il.com>,
 John Fastabend <john.fastabend@...il.com>,
 Jamal Hadi Salim <jhs@...atatu.com>, edumazet@...gle.com,
 Madhu Chittim <madhu.chittim@...el.com>, anthony.l.nguyen@...el.com,
 Simon Horman <horms@...nel.org>, przemyslaw.kitszel@...el.com,
 Jakub Kicinski <kuba@...nel.org>, intel-wired-lan@...ts.osuosl.org,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>
Subject: Re: [Intel-wired-lan] [PATCH v7 net-next 02/15] netlink: spec: add
 shaper YAML spec

Hi,

On 9/10/24 14:08, Paul Menzel wrote>> +config NET_SHAPER
>> +	bool
> 
> It’d be great if you added a help text/description.
> 
> […]

Thank you for the feedback.

The lack of description here is intentional: we don't want user to 
enable the knob explicitly, only via 'select'.

I'll handle the other comments in the next revision.

Cheers,

Paolo