netdev - Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45327ee6-e57c-4fec-bf43-86bd1338f5fb@intel.com>
Date: Thu, 19 Sep 2024 10:58:48 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>, "Vladimir
 Oltean" <vladimir.oltean@....com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Michal Kubecek
	<mkubecek@...e.cz>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
 ETHTOOL_GRXRINGS ioctl



On 9/13/2024 4:07 PM, Mogilappagari, Sudheer wrote:
> 
> 
>> -----Original Message-----
>> From: Vladimir Oltean <vladimir.oltean@....com>
>> Sent: Friday, September 13, 2024 3:49 PM
>> To: Mogilappagari, Sudheer <sudheer.mogilappagari@...el.com>
>> Cc: netdev@...r.kernel.org; Michal Kubecek <mkubecek@...e.cz>; Jakub
>> Kicinski <kuba@...nel.org>
>> Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
>> ETHTOOL_GRXRINGS ioctl
>>
>> Hi Sudheer,
>>
>> On Fri, Sep 13, 2024 at 10:43:19PM +0000, Mogilappagari, Sudheer wrote:
>>> Hi Vladimir, my understanding is ioctls are not used in ethtool
>>> netlink path. Can we use ETHTOOL_MSG_RINGS_GET
>> (tb[ETHTOOL_A_RINGS_RX]
>>> member) instead ?
>>
>> You mean this?
>>
>>   ``ETHTOOL_A_RINGS_RX``                u32     size of RX ring
> 
> Yes. I had meant ETHTOOL_A_RINGS_RX but I see it is ring size and not ring
> count. There seems to be no netlink message that fetches ringcount info. 
> 

We could extend the netlink interface to add this over netlink instead
of ioctl, but that hasn't been done yet.