netdev - Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241003091810.2zbbvod4jqq246lq@skbuf>
Date: Thu, 3 Oct 2024 12:18:10 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Michal Kubecek <mkubecek@...e.cz>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
 ETHTOOL_GRXRINGS ioctl

Hello Jake,

On Thu, Sep 19, 2024 at 10:58:48AM -0700, Jacob Keller wrote:
> We could extend the netlink interface to add this over netlink instead
> of ioctl, but that hasn't been done yet.

Let me understand how this will play out. So you're proposing that we
add a new netlink attribute in ETHTOOL_MSG_RSS_GET_REPLY, with Fixes:
7112a04664bf ("ethtool: add netlink based get rss support"), and this
gets backported to all stable kernels which include this commit?

And then also 'fix' ethtool to parse this new netlink attribute instead
of ETHTOOL_A_CHANNELS_RX_COUNT? Thus introducing another breakage: when
the new ethtool program runs with the old (aka unpatched stable) kernel?