[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9b668881-b933-4bae-a0da-a107d2b531e9@redhat.com>
Date: Thu, 19 Sep 2024 10:26:43 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Zijun Hu <zijun_hu@...oud.com>, Timur Tabi <timur@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH net-next v5] net: qcom/emac: Find sgmii_ops by
device_for_each_child()
On 9/17/24 03:57, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
>
> To prepare for constifying the following old driver core API:
>
> struct device *device_find_child(struct device *dev, void *data,
> int (*match)(struct device *dev, void *data));
> to new:
> struct device *device_find_child(struct device *dev, const void *data,
> int (*match)(struct device *dev, const void *data));
>
> The new API does not allow its match function (*match)() to modify
> caller's match data @*data, but emac_sgmii_acpi_match(), as the old
> API's match function, indeed modifies relevant match data, so it is
> not suitable for the new API any more, solved by implementing the same
> finding sgmii_ops function by correcting the function and using it
> as parameter of device_for_each_child() instead of device_find_child().
>
> By the way, this commit does not change any existing logic.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
## Form letter - net-next-closed
The merge window for v6.12 and therefore net-next is closed for new
drivers, features, code refactoring and optimizations. We are currently
accepting bug fixes only.
Please repost when net-next reopens after Sept 30th.
RFC patches sent for review only are obviously welcome at any time.
See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
Powered by blists - more mailing lists