netdev - Re: [PATCH net-next v5] net: qcom/emac: Find sgmii_ops by device_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f70ca3a8-2fe8-404c-8ead-7e7bc5417f52@icloud.com>
Date: Thu, 19 Sep 2024 19:27:00 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Paolo Abeni <pabeni@...hat.com>, Timur Tabi <timur@...nel.org>,
 "David S. Miller" <davem@...emloft.net>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH net-next v5] net: qcom/emac: Find sgmii_ops by
 device_for_each_child()

On 2024/9/19 16:26, Paolo Abeni wrote:
> On 9/17/24 03:57, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@...cinc.com>
>>
>> To prepare for constifying the following old driver core API:
>>
>> struct device *device_find_child(struct device *dev, void *data,
>>         int (*match)(struct device *dev, void *data));
>> to new:
>> struct device *device_find_child(struct device *dev, const void *data,
>>         int (*match)(struct device *dev, const void *data));
>>
>> The new API does not allow its match function (*match)() to modify
>> caller's match data @*data, but emac_sgmii_acpi_match(), as the old
>> API's match function, indeed modifies relevant match data, so it is
>> not suitable for the new API any more, solved by implementing the same
>> finding sgmii_ops function by correcting the function and using it
>> as parameter of device_for_each_child() instead of device_find_child().
>>
>> By the way, this commit does not change any existing logic.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> 
> ## Form letter - net-next-closed
> 
> The merge window for v6.12 and therefore net-next is closed for new
> drivers, features, code refactoring and optimizations. We are currently
> accepting bug fixes only.
> 
> Please repost when net-next reopens after Sept 30th.
> 
> RFC patches sent for review only are obviously welcome at any time.
>

thanks for your remainder. will post it after merge window is opened again.

and always welcome code reviewers to give comments before that.

(^^).

> See:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle