netdev - Re: [PATCH] xfrm: add SA information to the offloaded packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZvKPZvKw2hxO5GkK@gauss3.secunet.de>
Date: Tue, 24 Sep 2024 12:07:34 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Feng Wang <wangfe@...gle.com>
CC: Leon Romanovsky <leon@...nel.org>, <netdev@...r.kernel.org>,
	<antony.antony@...unet.com>
Subject: Re: [PATCH] xfrm: add SA information to the offloaded packet

On Wed, Sep 11, 2024 at 04:43:55PM -0700, Feng Wang wrote:
> Hi Steffen,
> 
> Can you reconsider the revert of the CL? Based on our discussion, I
> believe we've reached a consensus that the xfrm id is necessary.

I did not say it is necessary, all I want is a complete API that
exposes all xfrm stack features correctly to HW.

> If
> some customers prefer not to utilize it, we can extend the offload
> flag (something like XFRM_DEV_OFFLOAD_FLAG_ACQ) to manage this
> behavior. The default setting would remain consistent with the current
> implementation.

No new flags please.

The easiest thing would be to upstream your driver, that is the
prefered way and would just end this discussion.