netdev - Re: [PATCH net 2/2] net: add more sanity checks to qdisc_pkt_len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240925112733.5654dd49@fedora>
Date: Wed, 25 Sep 2024 11:27:33 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Joe Damato <jdamato@...tly.com>
Cc: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
 netdev@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>, Jonathan
 Davies <jonathan.davies@...anix.com>, eric.dumazet@...il.com
Subject: Re: [PATCH net 2/2] net: add more sanity checks to
 qdisc_pkt_len_init()

On Wed, 25 Sep 2024 11:24:04 -0700
Joe Damato <jdamato@...tly.com> wrote:

> On Wed, Sep 25, 2024 at 08:00:08PM +0200, Eric Dumazet wrote:
> > On Wed, Sep 25, 2024 at 7:52 PM Joe Damato <jdamato@...tly.com> wrote:  
> > >
> > > On Tue, Sep 24, 2024 at 03:02:57PM +0000, Eric Dumazet wrote:  
> > > > One path takes care of SKB_GSO_DODGY, assuming
> > > > skb->len is bigger than hdr_len.  
> > >
> > > My only comment, which you may feel free to ignore, is that we've
> > > recently merged a change to replace the term 'sanity check' in the
> > > code [1].
> > >
> > > Given that work is being done to replace terminology in the source
> > > code, I am wondering if that same ruling applies to commit messages.
> > >
> > > If so, perhaps the title of this commit can be adjusted?
> > >
> > > [1]: https://lore.kernel.org/netdev/20240912171446.12854-1-stephen@networkplumber.org/  
> > 
> > I guess I could write the changelog in French, to make sure it is all good.  
> 
> You could, but then I'd probably email you and remind you that the
> documentation explicitly says "It’s important to describe the change
> in plain English" [1].
> 
> > git log --oneline --grep "sanity check" | wc -l
> > 3397  
> 
> I don't know what this means. We've done it in the past and so
> should continue to do it in the future? OK.
> 
> > I dunno...  
> 
> Me either, but if code is being merged as recently as a few days ago
> to remove this term...
> 
> [1]: https://www.kernel.org/doc/html/v6.11/process/submitting-patches.html#describe-your-changes
> 

Less concerned about commit log or subject.
My patch was more about keeping non-inclusive naming out of current code base.