netdev - Re: vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c32f24e8-9e4e-4ee5-9b5d-276dc99ace9f@web.de>
Date: Thu, 26 Sep 2024 08:04:06 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Al Viro <viro@...iv.linux.org.uk>, virtualization@...ts.linux.dev,
 kvm@...r.kernel.org, netdev@...r.kernel.org,
 Eugenio Pérez <eperezma@...hat.com>,
 Jason Wang <jasowang@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: vhost-vdpa: Refactor copy_to_user() usage in
 vhost_vdpa_get_config()

>> Assign the return value from a copy_to_user() call to an additional
>> local variable so that a kvfree() call and return statement can be
>> omitted accordingly.
>
> Ugly and unidiomatic.
>
>> This issue was detected by using the Coccinelle software.
>
> What issue?

Opportunities for the reduction of duplicate source code.

Regards,
Markus