netdev - Re: [PATCH] vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240925205005.GL3550746@ZenIV>
Date: Wed, 25 Sep 2024 21:50:05 +0100
From: Al Viro <viro@...iv.linux.org.uk>
To: Markus Elfring <Markus.Elfring@....de>
Cc: virtualization@...ts.linux.dev, kvm@...r.kernel.org,
	netdev@...r.kernel.org,
	Eugenio Pérez <eperezma@...hat.com>,
	Jason Wang <jasowang@...hat.com>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Tiwei Bie <tiwei.bie@...el.com>,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] vhost-vdpa: Refactor copy_to_user() usage in
 vhost_vdpa_get_config()

On Wed, Sep 25, 2024 at 08:48:16PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 25 Sep 2024 20:36:35 +0200
> 
> Assign the return value from a copy_to_user() call to an additional
> local variable so that a kvfree() call and return statement can be
> omitted accordingly.

Ugly and unidiomatic.

> This issue was detected by using the Coccinelle software.

What issue?

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Nevermind (and I really need more coffee, seeing that I'd missed the
obvious indicator of garbage and failed to hit delete)...