netdev - Re: [PATCH] net: phy: realtek: Check the index value in led_hw_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e74c3f69-3c17-46bb-95c8-50075db39cb8@denx.de>
Date: Fri, 27 Sep 2024 14:12:09 +0200
From: Marek Vasut <marex@...x.de>
To: Hui Wang <hui.wang@...onical.com>, andrew@...n.ch, hkallweit1@...il.com,
 linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: realtek: Check the index value in
 led_hw_control_get

On 9/27/24 1:46 PM, Hui Wang wrote:
> Just like rtl8211f_led_hw_is_supported() and
> rtl8211f_led_hw_control_set(), the rtl8211f_led_hw_control_get() also
> needs to check the index value, otherwise the caller is likely to get
> an incorrect rules.
> 
> Fixes: 17784801d888 ("net: phy: realtek: Add support for PHY LEDs on RTL8211F")
> Signed-off-by: Hui Wang <hui.wang@...onical.com>
Reviewed-by: Marek Vasut <marex@...x.de>

Thanks !