netdev - Re: [PATCH net] net: add inline annotation to fix the build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5cb1a17-72e1-529c-0f46-404dcdb3e5f3@gmail.com>
Date: Thu, 3 Oct 2024 17:11:26 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Moon Yeounsu <yyyynoom@...il.com>, Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 linux@...ssschuh.net, j.granados@...sung.com, judyhsiao@...omium.org,
 James.Z.Li@...l.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Simon Horman <horms@...nel.org>, linux-sparse@...r.kernel.org
Subject: Re: [PATCH net] net: add inline annotation to fix the build warning

On 03/10/2024 16:33, Moon Yeounsu wrote:
> On 03/10/2024 15:19, Eric Dumazet wrote:
>> It also does not know about conditional locking, it is quite useless.
> So... What do you think about who wants to send the patch to silence
> the Sparse's warning message, nevertheless?

Fwiw, my experience is that if I can't explain the locking to sparse
 that's usually a sign that the code is too complex and needs to be
 rewritten.
In general I'm in favour of patches to fix sparse warnings.  In this
 case it looks like what's needed is __cond_acquires, but the patch
 to implement that in sparse[1] doesn't seem to have gotten anywhere
 near Luc's tree.  (Yet it's present and occasionally used in the
 kernel...)  CCing the sparse ML to find out why.

-ed

[1]: https://lore.kernel.org/all/CAHk-=wjZfO9hGqJ2_hGQG3U_XzSh9_XaXze=HgPdvJbgrvASfA@mail.gmail.com/#t