netdev - Re: [PATCH net] net: add inline annotation to fix the build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241003113947.6e605b8c@hermes.local>
Date: Thu, 3 Oct 2024 11:39:47 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: Moon Yeounsu <yyyynoom@...il.com>, Eric Dumazet <edumazet@...gle.com>,
 davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 linux@...ssschuh.net, j.granados@...sung.com, judyhsiao@...omium.org,
 James.Z.Li@...l.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Simon Horman <horms@...nel.org>, linux-sparse@...r.kernel.org
Subject: Re: [PATCH net] net: add inline annotation to fix the build warning

On Thu, 3 Oct 2024 17:11:26 +0100
Edward Cree <ecree.xilinx@...il.com> wrote:

> On 03/10/2024 16:33, Moon Yeounsu wrote:
> > On 03/10/2024 15:19, Eric Dumazet wrote:  
> >> It also does not know about conditional locking, it is quite useless.  
> > So... What do you think about who wants to send the patch to silence
> > the Sparse's warning message, nevertheless?  

In my experience, conditional locking is often a cause of bugs.