netdev - Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3Yc25zvs16DyXtKBLOg-5bH6wf20L1T9YQ+Nm3CC7QVSQ@mail.gmail.com>
Date: Thu, 3 Oct 2024 09:40:43 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: idosch@...dia.com, kuba@...nel.org, aleksander.lobakin@...el.com, 
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com, 
	gnault@...hat.com, bpoirier@...dia.com, b.galvani@...il.com, 
	razor@...ckwall.org, petrm@...dia.com, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 06/12] net: vxlan: make vxlan_snoop() return
 drop reasons

On Wed, Oct 2, 2024 at 9:35 PM Simon Horman <horms@...nel.org> wrote:
>
> On Tue, Oct 01, 2024 at 03:32:19PM +0800, Menglong Dong wrote:
> > Change the return type of vxlan_snoop() from bool to enum
> > skb_drop_reason. In this commit, two drop reasons are introduced:
> >
> >   SKB_DROP_REASON_VXLAN_INVALID_SMAC
> >   SKB_DROP_REASON_VXLAN_ENTRY_EXISTS
> >
> > Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> > ---
> > v4:
> > - rename SKB_DROP_REASON_VXLAN_INVALID_SMAC to
> >   SKB_DROP_REASON_MAC_INVALID_SOURCE
>
> super-nit: SKB_DROP_REASON_VXLAN_INVALID_SMAC was renamed in the code below
>            but not the patch description above
>

Oops, my mistake! What should I do with it? Is it worth
to send a new version?

Thanks!
Menglong Dong

> In any case, this looks good to me.
>
> Reviewed-by: Simon Horman <horms@...nel.org>