netdev - Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tctt7svco2xfmp7qr2rrgrpx6kzyvlaia2lxfqlunrdlgjny3h@77gxzrjooolu>
Date: Fri, 4 Oct 2024 01:20:03 +0200
From: Michal Kubecek <mkubecek@...e.cz>
To: Vladimir Oltean <vladimir.oltean@....com>
Cc: Jacob Keller <jacob.e.keller@...el.com>, 
	"Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
 ETHTOOL_GRXRINGS ioctl

On Thu, Oct 03, 2024 at 04:49:16PM +0300, Vladimir Oltean wrote:
> On Thu, Oct 03, 2024 at 01:09:47PM +0200, Michal Kubecek wrote:
> > I'm afraid we will have to keep the unfortunate ioctl fallback for quite
> > long. The only other option would be to only use netlink for RSS against
> > kernel which provides full information and use only ioctl against those
> > which don't.
> > 
> > Michal
> 
> So, then, is there anything blocking this patch?

I'm still not fully convinced that this mix of netlink and ioctl is
actually better than fully reverting to ioctl until we can get all
information via netlink.

Either way, I'm going to handle this before the end of this week so that
ethtool 6.11 can be released. At the moment I'm in favor of your patch,
however unhappy I'm about it.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (485 bytes)