netdev - RE: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089C7F00BCDDCBB678AF260D6722@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Fri, 4 Oct 2024 19:19:24 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Michal Kubecek <mkubecek@...e.cz>, Vladimir Oltean
	<vladimir.oltean@....com>
CC: "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jakub Kicinski
	<kuba@...nel.org>
Subject: RE: [PATCH ethtool] netlink: rss: retrieve ring count using
 ETHTOOL_GRXRINGS ioctl



> -----Original Message-----
> From: Michal Kubecek <mkubecek@...e.cz>
> Sent: Thursday, October 3, 2024 4:20 PM
> To: Vladimir Oltean <vladimir.oltean@....com>
> Cc: Keller, Jacob E <jacob.e.keller@...el.com>; Mogilappagari, Sudheer
> <sudheer.mogilappagari@...el.com>; netdev@...r.kernel.org; Jakub Kicinski
> <kuba@...nel.org>
> Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
> ETHTOOL_GRXRINGS ioctl
> 
> On Thu, Oct 03, 2024 at 04:49:16PM +0300, Vladimir Oltean wrote:
> > On Thu, Oct 03, 2024 at 01:09:47PM +0200, Michal Kubecek wrote:
> > > I'm afraid we will have to keep the unfortunate ioctl fallback for quite
> > > long. The only other option would be to only use netlink for RSS against
> > > kernel which provides full information and use only ioctl against those
> > > which don't.
> > >
> > > Michal
> >
> > So, then, is there anything blocking this patch?
> 
> I'm still not fully convinced that this mix of netlink and ioctl is
> actually better than fully reverting to ioctl until we can get all
> information via netlink.
> 
> Either way, I'm going to handle this before the end of this week so that
> ethtool 6.11 can be released. At the moment I'm in favor of your patch,
> however unhappy I'm about it.
> 
> Michal

I have no objection to your patch, I think its correct to do now. My suggestion was that we can improve the netlink interface for the future, and I believe we can make ethtool continue to use the existing ioctl interface on older kernels, but use the netlink interface once its available.