netdev - Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lxkqtnik6q6xjpjhgmy4kwbbsgtxwa7mszz7gcv3i2aafhkx4n@tdudjcsuxg7z>
Date: Sat, 5 Oct 2024 09:46:22 +0200
From: Michal Kubecek <mkubecek@...e.cz>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc: Vladimir Oltean <vladimir.oltean@....com>, 
	"Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
 ETHTOOL_GRXRINGS ioctl

On Fri, Oct 04, 2024 at 07:19:24PM +0000, Keller, Jacob E wrote:
> I have no objection to your patch, I think its correct to do now. My
> suggestion was that we can improve the netlink interface for the
> future, and I believe we can make ethtool continue to use the existing
> ioctl interface on older kernels, but use the netlink interface once
> its available.

This is not the problem. It's what we have been doing since netlink
interface was introduced and it's what we are going to be doing for
quite long.

What I'm unhappy about is the mix of netlink and ioctl where we use
netlink request for RSS but also an ioctl request to get the ring count.
I can't help wondering if it wouldn't make more sense to fallback to
ioctl fully unless we can retrieve full information via netlink.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)