netdev - Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e25afe6-cab3-4a0e-97e5-b82e9e97a8ab@intel.com>
Date: Mon, 7 Oct 2024 15:12:58 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Michal Kubecek <mkubecek@...e.cz>
CC: Vladimir Oltean <vladimir.oltean@....com>, "Mogilappagari, Sudheer"
	<sudheer.mogilappagari@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using
 ETHTOOL_GRXRINGS ioctl



On 10/5/2024 12:46 AM, Michal Kubecek wrote:
> On Fri, Oct 04, 2024 at 07:19:24PM +0000, Keller, Jacob E wrote:
>> I have no objection to your patch, I think its correct to do now. My
>> suggestion was that we can improve the netlink interface for the
>> future, and I believe we can make ethtool continue to use the existing
>> ioctl interface on older kernels, but use the netlink interface once
>> its available.
> 
> This is not the problem. It's what we have been doing since netlink
> interface was introduced and it's what we are going to be doing for
> quite long.
> 
> What I'm unhappy about is the mix of netlink and ioctl where we use
> netlink request for RSS but also an ioctl request to get the ring count.
> I can't help wondering if it wouldn't make more sense to fallback to
> ioctl fully unless we can retrieve full information via netlink.
> 
> Michal

That seems reasonable to me