netdev - Re: [PATCH net v4] net: dsa: lan9303: ensure chip reset and wait for READY status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241004115712.taqv5oolktcfhvak@skbuf>
Date: Fri, 4 Oct 2024 14:57:12 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: "A. Sverdlin" <alexander.sverdlin@...mens.com>
Cc: netdev@...r.kernel.org, Anatolij Gustschin <agust@...x.de>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net v4] net: dsa: lan9303: ensure chip reset and wait for
 READY status

On Fri, Oct 04, 2024 at 01:36:54PM +0200, A. Sverdlin wrote:
> From: Anatolij Gustschin <agust@...x.de>
> 
> Accessing device registers seems to be not reliable, the chip
> revision is sometimes detected wrongly (0 instead of expected 1).
> 
> Ensure that the chip reset is performed via reset GPIO and then
> wait for 'Device Ready' status in HW_CFG register before doing
> any register initializations.
> 
> Signed-off-by: Anatolij Gustschin <agust@...x.de>
> [alex: reworked using read_poll_timeout()]
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>

I see you're missing a Fixes: tag (meaning in this case: backport down
to all stable tree containing this commit). I think you can just post it
as a reply to this email, without resending, and it should get picked up
by maintainers through the same mechanism as Reviewed-by: tags.