netdev - Re: [PATCH net v4] net: dsa: lan9303: ensure chip reset and wait for READY status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6271d9229bd1f8d2cda09d9ebfafdfe5774617c5.camel@siemens.com>
Date: Fri, 4 Oct 2024 12:07:12 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "olteanv@...il.com" <olteanv@...il.com>
CC: "agust@...x.de" <agust@...x.de>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>, "andrew@...n.ch"
	<andrew@...n.ch>
Subject: Re: [PATCH net v4] net: dsa: lan9303: ensure chip reset and wait for
 READY status

Hi Vladimir!

On Fri, 2024-10-04 at 14:57 +0300, Vladimir Oltean wrote:
> On Fri, Oct 04, 2024 at 01:36:54PM +0200, A. Sverdlin wrote:
> > From: Anatolij Gustschin <agust@...x.de>
> > 
> > Accessing device registers seems to be not reliable, the chip
> > revision is sometimes detected wrongly (0 instead of expected 1).
> > 
> > Ensure that the chip reset is performed via reset GPIO and then
> > wait for 'Device Ready' status in HW_CFG register before doing
> > any register initializations.
> > 
> > Signed-off-by: Anatolij Gustschin <agust@...x.de>
> > [alex: reworked using read_poll_timeout()]
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> > ---
> 
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> 
> I see you're missing a Fixes: tag (meaning in this case: backport down
> to all stable tree containing this commit). I think you can just post it
> as a reply to this email, without resending, and it should get picked up
> by maintainers through the same mechanism as Reviewed-by: tags.

Well, the only meaningful would be the very first commit for lan9303:

Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")
Cc: <stable@...r.kernel.org>

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com