netdev - Re: [PATCH v2 net 3/6] bridge: Handle error of rtnl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33165f11-113f-4155-a551-7490be717686@blackwall.org>
Date: Sat, 5 Oct 2024 17:09:43 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org,
 Roopa Prabhu <roopa@...dia.com>
Subject: Re: [PATCH v2 net 3/6] bridge: Handle error of
 rtnl_register_module().

On 05/10/2024 01:23, Kuniyuki Iwashima wrote:
> Since introduced, br_vlan_rtnl_init() has been ignoring the returned
> value of rtnl_register_module(), which could fail.
> 
> Let's handle the errors by rtnl_register_module_many().
> 
> Fixes: 8dcea187088b ("net: bridge: vlan: add rtm definitions and dump support")
> Fixes: f26b296585dc ("net: bridge: vlan: add new rtm message support")
> Fixes: adb3ce9bcb0f ("net: bridge: vlan: add del rtm message support")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
> Cc: Roopa Prabhu <roopa@...dia.com>
> Cc: Nikolay Aleksandrov <razor@...ckwall.org>
> ---
>  net/bridge/br_netlink.c |  6 +++++-
>  net/bridge/br_private.h |  5 +++--
>  net/bridge/br_vlan.c    | 19 +++++++++----------
>  3 files changed, 17 insertions(+), 13 deletions(-)
> 

Oops, I guess copy/paste mistakes.
Thank you for fixing them!

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>