netdev - Re: [PATCH v2 net 2/6] vxlan: Handle error of rtnl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e739ce3-162f-4cdb-80b4-161e3c9583d8@blackwall.org>
Date: Sat, 5 Oct 2024 17:12:49 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org,
 Roopa Prabhu <roopa@...dia.com>
Subject: Re: [PATCH v2 net 2/6] vxlan: Handle error of rtnl_register_module().

On 05/10/2024 01:23, Kuniyuki Iwashima wrote:
> Since introduced, vxlan_vnifilter_init() has been ignoring the
> returned value of rtnl_register_module(), which could fail.
> 
> Let's handle the errors by rtnl_register_module_many().
> 
> Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---
> Cc: Roopa Prabhu <roopa@...dia.com>
> ---
>  drivers/net/vxlan/vxlan_core.c      |  6 +++++-
>  drivers/net/vxlan/vxlan_private.h   |  2 +-
>  drivers/net/vxlan/vxlan_vnifilter.c | 19 +++++++++----------
>  3 files changed, 15 insertions(+), 12 deletions(-)
> 

FWIW,
Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>