netdev - Re: [PATCH RFC net-next] net: phy: always set polarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e288f85c-2e5e-457f-b0d7-665c6410ccb4@lunn.ch>
Date: Sat, 5 Oct 2024 16:17:56 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Christian Marangi <ansuelsmth@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC net-next] net: phy: always set polarity_modes if op
 is supported

> I'll add "active-high" as an additional property then, as I found out
> that both, Aquantia and Intel/MaxLinear are technically speaking
> active-low by default (ie. after reset) and what we need to set is a
> property setting the LED to be driven active-high (ie. driving VDD
> rather than GND) instead. I hope it's not too late to make this change
> also for the Aquantia driver.

Adding a new property should not affect backwards compatibility, so it
should be safe to merge at any time.

	Andrew