netdev - Re: [PATCH] net: fix register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34f7eda9-e4e2-49e7-af88-82c377c8c7f7@gmail.com>
Date: Sun, 6 Oct 2024 21:05:52 +0300
From: Ivan Safonov <insafonov@...il.com>
To: "David S. Miller" <davem@...emloft.net>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Jiri Pirko <jiri@...nulli.us>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: fix register_netdev description

Please do not apply this.

On 10/6/24 19:57, Ivan Safonov wrote:
> register_netdev() does not expands the device name.
> 
> Signed-off-by: Ivan Safonov <insafonov@...il.com>
> ---
>   net/core/dev.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index cd479f5f22f6..06b13eef3628 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -10611,10 +10611,10 @@ EXPORT_SYMBOL_GPL(init_dummy_netdev);
>    *	chain. 0 is returned on success. A negative errno code is returned
>    *	on a failure to set up the device, or if the name is a duplicate.
>    *
> - *	This is a wrapper around register_netdevice that takes the rtnl semaphore
> - *	and expands the device name if you passed a format string to
> - *	alloc_netdev.
> + *	This is a wrapper around register_netdevice that takes
> + *	the rtnl semaphore.
>    */
> +
>   int register_netdev(struct net_device *dev)
>   {
>   	int err;