netdev - Re: [PATCH net-next v6 08/12] net: vxlan: use kfree_skb_reason() in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3ZDkjuu9TJQ_vmbky75T+bn32XMrMhQRi=rVtxgRXC_Zw@mail.gmail.com>
Date: Wed, 9 Oct 2024 09:38:24 +0800
From: Menglong Dong <menglong8.dong@...il.com>
To: Guillaume Nault <gnault@...hat.com>
Cc: idosch@...dia.com, kuba@...nel.org, aleksander.lobakin@...el.com, 
	horms@...nel.org, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, 
	dsahern@...nel.org, dongml2@...natelecom.cn, amcohen@...dia.com, 
	bpoirier@...dia.com, b.galvani@...il.com, razor@...ckwall.org, 
	petrm@...dia.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit()

On Wed, Oct 9, 2024 at 2:05 AM Guillaume Nault <gnault@...hat.com> wrote:
>
> On Tue, Oct 08, 2024 at 10:22:56PM +0800, Menglong Dong wrote:
> > Replace kfree_skb() with kfree_skb_reason() in vxlan_xmit(). Following
> > new skb drop reasons are introduced for vxlan:
> >
> > /* no remote found for xmit */
> > SKB_DROP_REASON_VXLAN_NO_REMOTE
> > /* packet without necessary metadata reached a device which is in
> >  * "eternal" mode
>
> That should be "external" mode (with an "x").
>
> > +     /**
> > +      * @SKB_DROP_REASON_TUNNEL_TXINFO: packet without necessary metadata
> > +      * reached a device which is in "eternal" mode.
>
> Here too.
>

Oh, my eyes!

I checked this document one by one, and I'm sure there
are no more typos besides this one.

And I'm sending the V7 now.

Thanks!
Menglong Dong

> > +      */
> > +     SKB_DROP_REASON_TUNNEL_TXINFO,
> >       /**
> >        * @SKB_DROP_REASON_LOCAL_MAC: the source MAC address is equal to
> >        * the MAC address of the local netdev.
> > --
> > 2.39.5
> >
>