netdev - Re: [PATCH net-next v6 08/12] net: vxlan: use kfree_skb_reason() in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoAwJCsACt=Cc6HtzCFgBq_TUhmJq7dSuYnbFF5XGETQ_Q@mail.gmail.com>
Date: Wed, 9 Oct 2024 10:29:04 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: Guillaume Nault <gnault@...hat.com>, idosch@...dia.com, kuba@...nel.org, 
	aleksander.lobakin@...el.com, horms@...nel.org, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, dsahern@...nel.org, 
	dongml2@...natelecom.cn, amcohen@...dia.com, bpoirier@...dia.com, 
	b.galvani@...il.com, razor@...ckwall.org, petrm@...dia.com, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit()

On Wed, Oct 9, 2024 at 9:37 AM Menglong Dong <menglong8.dong@...il.com> wrote:
>
> On Wed, Oct 9, 2024 at 2:05 AM Guillaume Nault <gnault@...hat.com> wrote:
> >
> > On Tue, Oct 08, 2024 at 10:22:56PM +0800, Menglong Dong wrote:
> > > Replace kfree_skb() with kfree_skb_reason() in vxlan_xmit(). Following
> > > new skb drop reasons are introduced for vxlan:
> > >
> > > /* no remote found for xmit */
> > > SKB_DROP_REASON_VXLAN_NO_REMOTE
> > > /* packet without necessary metadata reached a device which is in
> > >  * "eternal" mode
> >
> > That should be "external" mode (with an "x").
> >
> > > +     /**
> > > +      * @SKB_DROP_REASON_TUNNEL_TXINFO: packet without necessary metadata
> > > +      * reached a device which is in "eternal" mode.
> >
> > Here too.
> >
>
> Oh, my eyes!
>
> I checked this document one by one, and I'm sure there
> are no more typos besides this one.
>

You can try "codespell xxx.patch" to avoid typos easily before
submitting patches.