netdev - Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abc3516e-2c12-4612-9035-146b280b36df@quicinc.com>
Date: Fri, 11 Oct 2024 13:46:38 +0800
From: Jingyi Wang <quic_jingyw@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Richard
 Cochran" <richardcochran@...il.com>,
        <quic_tengfan@...cinc.com>, <quic_tingweiz@...cinc.com>,
        <quic_aiquny@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300
 platforms



On 10/10/2024 8:56 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 09, 2024 at 03:13:34PM GMT, Jingyi Wang wrote:
>> Add support for QCS8300 TLMM configuration and control via the
>> pinctrl framework.
>>
>> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
>> ---
>>  drivers/pinctrl/qcom/Kconfig.msm       |    7 +
>>  drivers/pinctrl/qcom/Makefile          |    1 +
>>  drivers/pinctrl/qcom/pinctrl-qcs8300.c | 1246 ++++++++++++++++++++++++++++++++
>>  3 files changed, 1254 insertions(+)
>>
> 
> [...]
> 
>> +	[125] = PINGROUP(125, phase_flag, _, _, _, _, _, _, _, _, _, egpio),
>> +	[126] = PINGROUP(126, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[127] = PINGROUP(127, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[128] = PINGROUP(128, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[129] = PINGROUP(129, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[130] = PINGROUP(130, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[131] = PINGROUP(131, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[132] = PINGROUP(132, _, _, _, _, _, _, _, _, _, _, egpio),
>> +	[133] = UFS_RESET(ufs_reset, 0x92000),
>> +	[134] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x89000, 15, 0),
>> +	[135] = SDC_QDSD_PINGROUP(sdc1_clk, 0x89000, 13, 6),
>> +	[136] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x89000, 11, 3),
>> +	[137] = SDC_QDSD_PINGROUP(sdc1_data, 0x89000, 9, 0),
>> +};
>> +
> 
> [...]
> 
>> +
>> +static const struct msm_pinctrl_soc_data qcs8300_pinctrl = {
>> +	.pins = qcs8300_pins,
>> +	.npins = ARRAY_SIZE(qcs8300_pins),
>> +	.functions = qcs8300_functions,
>> +	.nfunctions = ARRAY_SIZE(qcs8300_functions),
>> +	.groups = qcs8300_groups,
>> +	.ngroups = ARRAY_SIZE(qcs8300_groups),
>> +	.ngpios = 134,
> 
> I believe this should be 133.
> 
133 should be right, thanks for review, will fix that.
>> +	.wakeirq_map = qcs8300_pdc_map,
>> +	.nwakeirq_map = ARRAY_SIZE(qcs8300_pdc_map),
>> +	.egpio_func = 11,
>> +};
>> +
> 
Thanks,
Jingyi