netdev - Re: [PATCH v2] selftests: net/rds: add module not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53ab195125ebacfd182d004a5913e0da070c5984.camel@oracle.com>
Date: Fri, 11 Oct 2024 05:58:44 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "shuah@...nel.org" <shuah@...nel.org>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "alessandro.zanni87@...il.com"
	<alessandro.zanni87@...il.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "anupnewsmail@...il.com" <anupnewsmail@...il.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>,
        "skhan@...uxfoundation.org"
	<skhan@...uxfoundation.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2] selftests: net/rds: add module not found

On Thu, 2024-10-10 at 21:44 +0200, Alessandro Zanni wrote:
> This fix solves this error, when calling kselftest with targets
> "net/rds":
> 
> The error was found by running tests manually with the command:
> make kselftest TARGETS="net/rds"
> 
> The patch also specifies to import ip() function from the utils
> module.
> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@...il.com>
I think this one looks ok.  Thanks Alessandro!

Reviewed-by: Allison Henderson <allison.henderson@...cle.com>
> ---
> 
> Notes:
>     v2:
>       modified the way the parent path is added
>       added test to reproduce the error
> 
>  tools/testing/selftests/net/rds/test.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/rds/test.py
> b/tools/testing/selftests/net/rds/test.py
> index e6bb109bcead..4a7178d11193 100755
> --- a/tools/testing/selftests/net/rds/test.py
> +++ b/tools/testing/selftests/net/rds/test.py
> @@ -14,8 +14,11 @@ import sys
>  import atexit
>  from pwd import getpwuid
>  from os import stat
> -from lib.py import ip
>  
> +# Allow utils module to be imported from different directory
> +this_dir = os.path.dirname(os.path.realpath(__file__))
> +sys.path.append(os.path.join(this_dir, "../"))
> +from lib.py.utils import ip
>  
>  libc = ctypes.cdll.LoadLibrary('libc.so.6')
>  setns = libc.setns