netdev - Re: [PATCH 0/5] virtio_net: enable premapped mode by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241014005529-mutt-send-email-mst@kernel.org>
Date: Mon, 14 Oct 2024 00:57:41 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	virtualization@...ts.linux.dev,
	Darren Kenny <darren.kenny@...cle.com>,
	Si-Wei Liu <si-wei.liu@...cle.com>
Subject: Re: [PATCH 0/5] virtio_net: enable premapped mode by default

On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote:
> In the last linux version, we disabled this feature to fix the
> regress[1].
> 
> The patch set is try to fix the problem and re-enable it.
> 
> More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com
> 
> Thanks.
> 
> [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com

Darren, you previously reported crashes with a patch very similar to 1/5.
Can you please test this patchset and report whether they
are still observed?
If yes, any data on how to reproduce would be very benefitial for Xuan
Zhuo.


> Xuan Zhuo (5):
>   virtio-net: fix overflow inside virtnet_rq_alloc
>   virtio_net: introduce vi->mode
>   virtio_net: big mode skip the unmap check
>   virtio_net: enable premapped mode for merge and small by default
>   virtio_net: rx remove premapped failover code
> 
>  drivers/net/virtio_net.c | 168 ++++++++++++++++++++++++---------------
>  1 file changed, 105 insertions(+), 63 deletions(-)
> 
> --
> 2.32.0.3.g01195cf9f