netdev - Re: [PATCH 0/5] virtio_net: enable premapped mode by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2bjzkeb2u.fsf@oracle.com>
Date: Wed, 16 Oct 2024 08:55:21 +0100
From: Darren Kenny <darren.kenny@...cle.com>
To: "Michael S. Tsirkin" <mst@...hat.com>,
        Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>
Cc: netdev@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
        Eugenio
 Pérez
 <eperezma@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>, virtualization@...ts.linux.dev,
        Si-Wei Liu
 <si-wei.liu@...cle.com>
Subject: Re: [PATCH 0/5] virtio_net: enable premapped mode by default

Hi Michael,

On Monday, 2024-10-14 at 00:57:41 -04, Michael S. Tsirkin wrote:
> On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote:
>> In the last linux version, we disabled this feature to fix the
>> regress[1].
>> 
>> The patch set is try to fix the problem and re-enable it.
>> 
>> More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com
>> 
>> Thanks.
>> 
>> [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com
>
> Darren, you previously reported crashes with a patch very similar to 1/5.
> Can you please test this patchset and report whether they
> are still observed?
> If yes, any data on how to reproduce would be very benefitial for Xuan
> Zhuo.
>

I aim to get to this in the next week, but I don't currently have
access to a system to test it, it will take a few days at least before I
can get one.

Thanks,

Darren.


>
>> Xuan Zhuo (5):
>>   virtio-net: fix overflow inside virtnet_rq_alloc
>>   virtio_net: introduce vi->mode
>>   virtio_net: big mode skip the unmap check
>>   virtio_net: enable premapped mode for merge and small by default
>>   virtio_net: rx remove premapped failover code
>> 
>>  drivers/net/virtio_net.c | 168 ++++++++++++++++++++++++---------------
>>  1 file changed, 105 insertions(+), 63 deletions(-)
>> 
>> --
>> 2.32.0.3.g01195cf9f