netdev - Re: [PATCH net-next v3 1/2] Convert neighbour-table to use hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241014224332.5038-1-kuniyu@amazon.com>
Date: Mon, 14 Oct 2024 15:43:32 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <gnaaman@...venets.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<kuniyu@...zon.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next v3 1/2] Convert neighbour-table to use hlist

From: Gilad Naaman <gnaaman@...venets.com>
Date: Sun, 13 Oct 2024 10:45:21 +0000
> > The current neigh_for_each() is only used in spectrum_router.c
> > and can be moved to mlxsw_sp_neigh_rif_made_sync_each() with
> > the new macro used.
> 
> Oh, I completely missed that it exists, sorry.
> 
> > Let's split this patch for ease of review.
> > 
> >   1. Add hlist_node and link/unlink by hlist_add() / hlist_del()
> >   2. Define neigh_for_each() macro and move the current
> >      neigh_for_each() to mlxsw_sp_neigh_rif_made_sync_each()
> >   3. Rewrite the seq_file part with macro
> >   4. Convert the rest of while()/for() with macro
> >   5. Remove ->next
> 
> Just making sure, you mean that in (1.) I should add hlist_node *alongside*
> the current `struct neighbour __rcu *next`, and only remove this duplication in
> (5.)?

Right, it will allow part-by-part changes that are easier to review.