netdev - Re: [PATCH net-next v3 1/2] Convert neighbour-table to use hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241013104521.3844432-1-gnaaman@drivenets.com>
Date: Sun, 13 Oct 2024 10:45:21 +0000
From: Gilad Naaman <gnaaman@...venets.com>
To: kuniyu@...zon.com
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	gnaaman@...venets.com,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net-next v3 1/2] Convert neighbour-table to use hlist

> The current neigh_for_each() is only used in spectrum_router.c
> and can be moved to mlxsw_sp_neigh_rif_made_sync_each() with
> the new macro used.

Oh, I completely missed that it exists, sorry.

> Let's split this patch for ease of review.
> 
>   1. Add hlist_node and link/unlink by hlist_add() / hlist_del()
>   2. Define neigh_for_each() macro and move the current
>      neigh_for_each() to mlxsw_sp_neigh_rif_made_sync_each()
>   3. Rewrite the seq_file part with macro
>   4. Convert the rest of while()/for() with macro
>   5. Remove ->next

Just making sure, you mean that in (1.) I should add hlist_node *alongside*
the current `struct neighbour __rcu *next`, and only remove this duplication in
(5.)?