netdev - Re: [PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for clarity and correctness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241014081823.GL77519@kernel.org>
Date: Mon, 14 Oct 2024 09:18:23 +0100
From: Simon Horman <horms@...nel.org>
To: Sky Huang <SkyLake.Huang@...iatek.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Qingfang Deng <dqfext@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Steven Liu <Steven.Liu@...iatek.com>
Subject: Re: [PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for
 clarity and correctness

On Mon, Oct 14, 2024 at 12:05:21PM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> 
> This patch does the following clean-up:
> 1. Fix spelling errors and rearrange variables with reverse
>    Xmas tree order.
> 2. Shrink mtk-ge-soc.c line wrapping to 80 characters.
> 3. Propagate error code correctly in cal_cycle().
> 4. Fix some functions with FIELD_PREP()/FIELD_GET().
> 5. Remove unnecessary outer parens of supported_triggers var.
> 
> Signed-off-by: SkyLake.Huang <skylake.huang@...iatek.com>
> ---
> This patch is derived from Message ID:
> 20241004102413.5838-9-SkyLake.Huang@...iatek.com

Hi Sky,

I think this patch is trying to do two many things (at least 5 are listed
above). Please consider breaking this up into separate patches, perhaps
one for each of the points above.

Also, I think it would be best to drop the following changes unless you are
touching those lines for some other reason [1] or are preparing to do so:

* xmas tree
* 80 character lines
* parentheses updates

[1] https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches