netdev - Re: [PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for clarity and correctness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2c24d063bea99be5380203ec4fafe3e4f0f9043.camel@mediatek.com>
Date: Tue, 15 Oct 2024 17:18:49 +0000
From: SkyLake Huang (黃啟澤)
	<SkyLake.Huang@...iatek.com>
To: "horms@...nel.org" <horms@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>, "hkallweit1@...il.com" <hkallweit1@...il.com>,
	"daniel@...rotopia.org" <daniel@...rotopia.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for
 clarity and correctness

On Mon, 2024-10-14 at 09:18 +0100, Simon Horman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Mon, Oct 14, 2024 at 12:05:21PM +0800, Sky Huang wrote:
> > From: "SkyLake.Huang" <skylake.huang@...iatek.com>
> > 
> > This patch does the following clean-up:
> > 1. Fix spelling errors and rearrange variables with reverse
> >    Xmas tree order.
> > 2. Shrink mtk-ge-soc.c line wrapping to 80 characters.
> > 3. Propagate error code correctly in cal_cycle().
> > 4. Fix some functions with FIELD_PREP()/FIELD_GET().
> > 5. Remove unnecessary outer parens of supported_triggers var.
> > 
> > Signed-off-by: SkyLake.Huang <skylake.huang@...iatek.com>
> > ---
> > This patch is derived from Message ID:
> > 20241004102413.5838-9-SkyLake.Huang@...iatek.com
> 
> Hi Sky,
> 
> I think this patch is trying to do two many things (at least 5 are
> listed
> above). Please consider breaking this up into separate patches,
> perhaps
> one for each of the points above.
> 
> Also, I think it would be best to drop the following changes unless
> you are
> touching those lines for some other reason [1] or are preparing to do
> so:
> 
> * xmas tree
> * 80 character lines
> * parentheses updates
> 
> [1] 
> https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches

Hi Simon,
  Reverse Xmas tree style & 80 char preferences come from your advise
in  
https://lore.kernel.org/all/20240530034844.11176-6-SkyLake.Huang@mediatek.com/
  Parens removing comes from Daniel's advise in 
https://lore.kernel.org/all/20240701105417.19941-14-SkyLake.Huang@mediatek.com/

  Because previous patchset(
https://lore.kernel.org/all/20240701105417.19941-1-SkyLake.Huang@mediatek.com/
) is too large, I guess it's better to commit this change first so that
I can handle the rest. And this should be "some other reason"?
  And since this patch is simple clean-ups, is it necessary to separate
it?

BRs,
Sky