netdev - Re: [PATCH net-next v3 1/9] af_packet: avoid erroring out after sock_init_data() in packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ0i+k_wHn-aoafY1V+mJ8TAS1DzQKnu1KkjusAWLNuyg@mail.gmail.com>
Date: Tue, 15 Oct 2024 10:01:17 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Ignat Korchagin <ignat@...udflare.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Marcel Holtmann <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, 
	Luiz Augusto von Dentz <luiz.dentz@...il.com>, Oliver Hartkopp <socketcan@...tkopp.net>, 
	Marc Kleine-Budde <mkl@...gutronix.de>, Alexander Aring <alex.aring@...il.com>, 
	Stefan Schmidt <stefan@...enfreihafen.org>, Miquel Raynal <miquel.raynal@...tlin.com>, 
	David Ahern <dsahern@...nel.org>, Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
	linux-bluetooth@...r.kernel.org, linux-can@...r.kernel.org, 
	linux-wpan@...r.kernel.org, kernel-team@...udflare.com, kuniyu@...zon.com, 
	alibuda@...ux.alibaba.com
Subject: Re: [PATCH net-next v3 1/9] af_packet: avoid erroring out after
 sock_init_data() in packet_create()

On Mon, Oct 14, 2024 at 5:38 PM Ignat Korchagin <ignat@...udflare.com> wrote:
>
> After sock_init_data() the allocated sk object is attached to the provided
> sock object. On error, packet_create() frees the sk object leaving the
> dangling pointer in the sock object on return. Some other code may try
> to use this pointer and cause use-after-free.
>
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Ignat Korchagin <ignat@...udflare.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.