netdev - Re: [PATCH net-next v3 2/9] Bluetooth: L2CAP: do not leave dangling sk pointer on error in l2cap_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLSebTHBz5k8GTS8+qMEn-tv66xanzypBbQBsxtDs69yQ@mail.gmail.com>
Date: Tue, 15 Oct 2024 10:03:30 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: ignat@...udflare.com, alex.aring@...il.com, alibuda@...ux.alibaba.com, 
	davem@...emloft.net, dsahern@...nel.org, johan.hedberg@...il.com, 
	kernel-team@...udflare.com, kuba@...nel.org, linux-bluetooth@...r.kernel.org, 
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-wpan@...r.kernel.org, luiz.dentz@...il.com, marcel@...tmann.org, 
	miquel.raynal@...tlin.com, mkl@...gutronix.de, netdev@...r.kernel.org, 
	pabeni@...hat.com, socketcan@...tkopp.net, stefan@...enfreihafen.org, 
	willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next v3 2/9] Bluetooth: L2CAP: do not leave dangling
 sk pointer on error in l2cap_sock_create()

On Mon, Oct 14, 2024 at 11:23 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> From: Ignat Korchagin <ignat@...udflare.com>
> Date: Mon, 14 Oct 2024 16:38:01 +0100
> > bt_sock_alloc() allocates the sk object and attaches it to the provided
> > sock object. On error l2cap_sock_alloc() frees the sk object, but the
> > dangling pointer is still attached to the sock object, which may create
> > use-after-free in other code.
> >
> > Signed-off-by: Ignat Korchagin <ignat@...udflare.com>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>
>
> Checked all bt_sock_alloc() paths and confirmed only rfcomm and l2cap
> need changes.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>