[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2aa7370c-648d-4353-8f49-555af4391d6b@molgen.mpg.de>
Date: Wed, 16 Oct 2024 06:16:54 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Paolo Abeni <pabeni@...hat.com>
Cc: intel-wired-lan@...ts.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@...el.com>, netdev@...r.kernel.org,
Tony Nguyen <anthony.l.nguyen@...el.com>, Wenjun Wu <wenjun1.wu@...el.com>,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] virtchnl: fix m68k build.
Dear Paolo,
Thank you for the patch. I’d remove the dot/period at the end of the
summary/title though, and maybe I’d be also more specific:
virtchnl: Introduce padding field to fix m68k build
Am 15.10.24 um 15:56 schrieb Paolo Abeni:
> The kernel test robot reported a build failure on m68k in the intel
> driver due to the recent shapers-related changes.
>
> The mentioned arch has funny alignment properties, let's be explicit
> about the binary layout expectation introducing a padding field.
>
> Fixes: 608a5c05c39b ("virtchnl: support queue rate limit and quanta size configuration")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410131710.71Wt6LKO-lkp@intel.com/
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
> include/linux/avf/virtchnl.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
> index 223e433c39fe..13a11f3c09b8 100644
> --- a/include/linux/avf/virtchnl.h
> +++ b/include/linux/avf/virtchnl.h
> @@ -1499,6 +1499,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_queue_chunk);
>
> struct virtchnl_quanta_cfg {
> u16 quanta_size;
> + u16 pad;
> struct virtchnl_queue_chunk queue_select;
> };
Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
Kind regards,
Paul
Powered by blists - more mailing lists