netdev - Re: [Intel-wired-lan] [PATCH iwl-next] virtchnl: fix m68k build.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98b5bef5-d5a8-45d5-8fe8-f9c34eb5ab84@intel.com>
Date: Wed, 16 Oct 2024 15:49:47 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Paolo Abeni <pabeni@...hat.com>, <intel-wired-lan@...ts.osuosl.org>
CC: Przemek Kitszel <przemyslaw.kitszel@...el.com>, <netdev@...r.kernel.org>,
	Tony Nguyen <anthony.l.nguyen@...el.com>, Wenjun Wu <wenjun1.wu@...el.com>,
	Jakub Kicinski <kuba@...nel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next] virtchnl: fix m68k build.



On 10/15/2024 6:56 AM, Paolo Abeni wrote:
> The kernel test robot reported a build failure on m68k in the intel
> driver due to the recent shapers-related changes.
> 
> The mentioned arch has funny alignment properties, let's be explicit
> about the binary layout expectation introducing a padding field.
> 
> Fixes: 608a5c05c39b ("virtchnl: support queue rate limit and quanta size configuration")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410131710.71Wt6LKO-lkp@intel.com/
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  include/linux/avf/virtchnl.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/avf/virtchnl.h b/include/linux/avf/virtchnl.h
> index 223e433c39fe..13a11f3c09b8 100644
> --- a/include/linux/avf/virtchnl.h
> +++ b/include/linux/avf/virtchnl.h
> @@ -1499,6 +1499,7 @@ VIRTCHNL_CHECK_STRUCT_LEN(8, virtchnl_queue_chunk);
>  
>  struct virtchnl_quanta_cfg {
>  	u16 quanta_size;
> +	u16 pad;
>  	struct virtchnl_queue_chunk queue_select;

There's a hidden 2 byte padding because queue_select requires 4-byte
alignment. We assume this, as the VIRTCHNL_CHECK_STRUCT_LEN for this
structure is 12 bytes.

On mk68k, we must not be adding this padding, which results in a 10 byte
structure, failing the size check for VIRTCHNL_CHECK_STRUCT_LEN,
resulting in the compilation error?

Adding the explicit size aligns with the actual expected layout and size
for this structure, fixing mk68k without affecting the other architectures.

Ok.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  };
>