netdev - Re: [PATCH 10/13] wifi: qtnfmac: use always-managed version of pcim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y12o4ced.fsf@kernel.org>
Date: Wed, 16 Oct 2024 12:36:58 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Damien Le Moal <dlemoal@...nel.org>,  Niklas Cassel <cassel@...nel.org>,
  Sergey Shtylyov <s.shtylyov@....ru>,  Basavaraj Natikar
 <basavaraj.natikar@....com>,  Jiri Kosina <jikos@...nel.org>,  Benjamin
 Tissoires <bentiss@...nel.org>,  Arnd Bergmann <arnd@...db.de>,  Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>,  Alex Dubov <oakad@...oo.com>,
  Sudarsana Kalluru <skalluru@...vell.com>,  Manish Chopra
 <manishc@...vell.com>,  "David S. Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Rasesh Mody <rmody@...vell.com>,
  GR-Linux-NIC-Dev@...vell.com,  Igor Mitsyanko <imitsyanko@...ntenna.com>,
  Sergey Matyukevich <geomatsi@...il.com>,  Sanjay R Mehta
 <sanju.mehta@....com>,  Shyam Sundar S K <Shyam-sundar.S-k@....com>,  Jon
 Mason <jdmason@...zu.us>,  Dave Jiang <dave.jiang@...el.com>,  Allen Hubbe
 <allenbh@...il.com>,  Bjorn Helgaas <bhelgaas@...gle.com>,  Alex
 Williamson <alex.williamson@...hat.com>,  Juergen Gross <jgross@...e.com>,
  Stefano Stabellini <sstabellini@...nel.org>,  Oleksandr Tyshchenko
 <oleksandr_tyshchenko@...m.com>,  Jaroslav Kysela <perex@...ex.cz>,
  Takashi Iwai <tiwai@...e.com>,  Chen Ni <nichen@...as.ac.cn>,  Mario
 Limonciello <mario.limonciello@....com>,  Ricky Wu <ricky_wu@...ltek.com>,
  Al Viro <viro@...iv.linux.org.uk>,  Breno Leitao <leitao@...ian.org>,
  Kevin Tian <kevin.tian@...el.com>,  Thomas Gleixner <tglx@...utronix.de>,
  Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,  Andy
 Shevchenko
 <andriy.shevchenko@...ux.intel.com>,  Mostafa Saleh <smostafa@...gle.com>,
  Jason Gunthorpe <jgg@...pe.ca>,  Yi Liu <yi.l.liu@...el.com>,  Christian
 Brauner <brauner@...nel.org>,  Ankit Agrawal <ankita@...dia.com>,  Eric
 Auger <eric.auger@...hat.com>,  Reinette Chatre
 <reinette.chatre@...el.com>,  Ye Bin <yebin10@...wei.com>,  Marek
 Marczykowski-Górecki <marmarek@...isiblethingslab.com>,
  Pierre-Louis
 Bossart <pierre-louis.bossart@...ux.dev>,  Peter Ujfalusi
 <peter.ujfalusi@...ux.intel.com>,  Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>,  Kai Vehmanen
 <kai.vehmanen@...ux.intel.com>,  Rui Salvaterra <rsalvaterra@...il.com>,
  linux-ide@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-input@...r.kernel.org,  netdev@...r.kernel.org,
  linux-wireless@...r.kernel.org,  ntb@...ts.linux.dev,
  linux-pci@...r.kernel.org,  kvm@...r.kernel.org,
  xen-devel@...ts.xenproject.org,  linux-sound@...r.kernel.org
Subject: Re: [PATCH 10/13] wifi: qtnfmac: use always-managed version of
 pcim_intx()

Philipp Stanner <pstanner@...hat.com> writes:

> pci_intx() is a hybrid function which can sometimes be managed through
> devres. To remove this hybrid nature from pci_intx(), it is necessary to
> port users to either an always-managed or a never-managed version.
>
> qtnfmac enables its PCI-Device with pcim_enable_device(). Thus, it needs
> the always-managed version.
>
> Replace pci_intx() with pcim_intx().
>
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Feel free to take this via the PCI tree:

Acked-by: Kalle Valo <kvalo@...nel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches