netdev - Re: [PATCH 09/13] ata: Use always-managed version of pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a32f0891-936b-4cce-a874-78b1865717ae@omp.ru>
Date: Wed, 16 Oct 2024 22:49:02 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Philipp Stanner <pstanner@...hat.com>, Damien Le Moal
	<dlemoal@...nel.org>, Niklas Cassel <cassel@...nel.org>, Basavaraj Natikar
	<basavaraj.natikar@....com>, Jiri Kosina <jikos@...nel.org>, Benjamin
 Tissoires <bentiss@...nel.org>, Arnd Bergmann <arnd@...db.de>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Alex Dubov <oakad@...oo.com>,
	Sudarsana Kalluru <skalluru@...vell.com>, Manish Chopra
	<manishc@...vell.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Rasesh Mody <rmody@...vell.com>,
	<GR-Linux-NIC-Dev@...vell.com>, Igor Mitsyanko <imitsyanko@...ntenna.com>,
	Sergey Matyukevich <geomatsi@...il.com>, Kalle Valo <kvalo@...nel.org>,
	Sanjay R Mehta <sanju.mehta@....com>, Shyam Sundar S K
	<Shyam-sundar.S-k@....com>, Jon Mason <jdmason@...zu.us>, Dave Jiang
	<dave.jiang@...el.com>, Allen Hubbe <allenbh@...il.com>, Bjorn Helgaas
	<bhelgaas@...gle.com>, Alex Williamson <alex.williamson@...hat.com>, Juergen
 Gross <jgross@...e.com>, Stefano Stabellini <sstabellini@...nel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>, Jaroslav Kysela
	<perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Chen Ni
	<nichen@...as.ac.cn>, Mario Limonciello <mario.limonciello@....com>, Ricky Wu
	<ricky_wu@...ltek.com>, Al Viro <viro@...iv.linux.org.uk>, Breno Leitao
	<leitao@...ian.org>, Kevin Tian <kevin.tian@...el.com>, Thomas Gleixner
	<tglx@...utronix.de>, Ilpo Järvinen
	<ilpo.jarvinen@...ux.intel.com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Mostafa Saleh <smostafa@...gle.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Yi Liu <yi.l.liu@...el.com>, Christian
 Brauner <brauner@...nel.org>, Ankit Agrawal <ankita@...dia.com>, Eric Auger
	<eric.auger@...hat.com>, Reinette Chatre <reinette.chatre@...el.com>, Ye Bin
	<yebin10@...wei.com>, Marek Marczykowski-Górecki
	<marmarek@...isiblethingslab.com>, Pierre-Louis Bossart
	<pierre-louis.bossart@...ux.dev>, Peter Ujfalusi
	<peter.ujfalusi@...ux.intel.com>, Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>, Kai Vehmanen
	<kai.vehmanen@...ux.intel.com>, Rui Salvaterra <rsalvaterra@...il.com>
CC: <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-input@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-wireless@...r.kernel.org>, <ntb@...ts.linux.dev>,
	<linux-pci@...r.kernel.org>, <kvm@...r.kernel.org>,
	<xen-devel@...ts.xenproject.org>, <linux-sound@...r.kernel.org>
Subject: Re: [PATCH 09/13] ata: Use always-managed version of pci_intx()

On 10/15/24 9:51 PM, Philipp Stanner wrote:

> pci_intx() is a hybrid function which can sometimes be managed through
> devres. To remove this hybrid nature from pci_intx(), it is necessary to
> port users to either an always-managed or a never-managed version.
> 
> All users in ata enable their PCI-Device with pcim_enable_device(). Thus,
> they need the always-managed version.
> 
> Replace pci_intx() with pcim_intx().
> 
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey