[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <36e86177-a220-494d-8b25-55ce62cf054d@collabora.com>
Date: Wed, 16 Oct 2024 12:39:59 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
<matthias.bgg@...il.com>, Richard Cochran <richardcochran@...il.com>
Cc: kernel@...labora.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
Jianguo Zhang <jianguo.zhang@...iatek.com>,
Macpaul Lin <macpaul.lin@...iatek.com>,
Hsuan-Yu Lin <shane.lin@...onical.com>
Subject: Re: [PATCH 1/2] arm64: dts: mediatek: mt8188: Add ethernet node
Il 15/10/24 20:15, Nícolas F. R. A. Prado ha scritto:
> Describe the ethernet present on the MT8188.
>
> Signed-off-by: Jianguo Zhang <jianguo.zhang@...iatek.com>
> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> Signed-off-by: Hsuan-Yu Lin <shane.lin@...onical.com>
> [Cleaned up to pass dtbs_check, follow DTS style guidelines, removed
> hardcoded mac address and split between mt8188 and genio700 commits]
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8188.dtsi | 95 ++++++++++++++++++++++++++++++++
> 1 file changed, 95 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index b493207a1b688dba51bf5e0e469349263f54ca94..9e3981d6d5cfc8201d8caef256de1299aa8199e3 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -1647,6 +1647,101 @@ spi5: spi@...19000 {
> status = "disabled";
> };
>
> + eth: ethernet@...21000 {
> + compatible = "mediatek,mt8188-gmac", "mediatek,mt8195-gmac",
> + "snps,dwmac-5.10a";
> + reg = <0 0x11021000 0 0x4000>;
> + interrupts = <GIC_SPI 716 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "macirq";
> + clocks = <&pericfg_ao CLK_PERI_AO_ETHERNET>,
> + <&pericfg_ao CLK_PERI_AO_ETHERNET_BUS>,
> + <&topckgen CLK_TOP_SNPS_ETH_250M>,
> + <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>,
> + <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>,
> + <&pericfg_ao CLK_PERI_AO_ETHERNET_MAC>;
clock-names = "axi", "apb", "mac_main", "ptp_ref",
"rmii_internal", "mac_cg";
Since we can compress clock-names, we should just do that :-)
> + clock-names = "axi",
> + "apb",
> + "mac_main",
> + "ptp_ref",
> + "rmii_internal",
> + "mac_cg";
> + assigned-clocks = <&topckgen CLK_TOP_SNPS_ETH_250M>,
> + <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>,
> + <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>;
> + assigned-clock-parents = <&topckgen CLK_TOP_ETHPLL_D2>,
> + <&topckgen CLK_TOP_ETHPLL_D8>,
> + <&topckgen CLK_TOP_ETHPLL_D10>;
> + power-domains = <&spm MT8188_POWER_DOMAIN_ETHER>;
> + mediatek,pericfg = <&infracfg_ao>;
> + snps,axi-config = <&stmmac_axi_setup>;
> + snps,mtl-rx-config = <&mtl_rx_setup>;
> + snps,mtl-tx-config = <&mtl_tx_setup>;
> + snps,txpbl = <16>;
> + snps,rxpbl = <16>;
> + snps,clk-csr = <0>;
> + status = "disabled";
Well, the MDIO bus is part of the IP anyway, so I think we can just put it here.
eth_mdio: mdio {
compatible = "snps,dwmac-mdio";
#address-cells = <1>;
#size-cells = <0>;
};
> +
> + stmmac_axi_setup: stmmac-axi-config {
Please reorder:
snps,blen = <0 0 0 0 16 8 4>;
snps,rd_osr_lmt = <0x7>;
snps,wr_osr_lmt = <0x7>;
Cheers,
Angelo
Powered by blists - more mailing lists