netdev - Re: [PATCH net-next v2 0/5] Removing more phylink cruft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241016164241.6c39ac9d@fedora.home>
Date: Wed, 16 Oct 2024 16:42:41 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>, Jakub
 Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Paolo Abeni
 <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next v2 0/5] Removing more phylink cruft

Hi,

On Wed, 16 Oct 2024 10:57:29 +0100
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> Hi,
> 
> Continuing on with the cleanups, this patch series removes
> dsa_port_phylink_mac_select_pcs() which is no longer required. This
> will have no functional effect as phylink does this:
> 
>         bool using_mac_select_pcs = false;
> 
>         if (mac_ops->mac_select_pcs &&
>             mac_ops->mac_select_pcs(config, PHY_INTERFACE_MODE_NA) !=
>               ERR_PTR(-EOPNOTSUPP))
>                 using_mac_select_pcs = true;
> 
> and no mac_select_pcs() method is equivalent to a mac_select_pcs()
> that returns -EOPNOTSUPP.
> 
> We then make mv88e6xxx_mac_select_pcs() return NULL, as we don't want
> to invoke this old behaviour anymore - mv88e6xxx doesn't require it.
> 
> Then, allow phylink to remove PCS, which has been a long standing
> behavioural oddity.
> 
> Remove the use of pl->pcs when validating as this will never be
> non-NULL unless "using_mac_select_pcs" was set.
> 
> This then clears the way to removing using_mac_select_pcs from phylink
> and the check.

I don't have any setup with such a switch or that could trigger the
PCS removal, so I couldn't fully test it. However it does look good to
me :)

For the series,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Maxime